refactor: improve test patterns #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Default expect_valid_linking and expect_invalid_linking to JavaScript - Add expect_invalid! macro for multi-file tests with JSON-like syntax - Convert .contains() assertions to snapshots in dump_tests.rs - Remove redundant assertions where snapshots already exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
expect_valid_linkingandexpect_invalid_linkingto JavaScript, removing the need to pass&LANGparameterexpect_invalid!macro for multi-file tests with JSON-like colon syntax.contains()assertions to snapshots indump_tests.rsTest plan